From 5cea2de52c53331984df91813556e9944173655e Mon Sep 17 00:00:00 2001
From: Ophestra <cat@gensokyo.uk>
Date: Wed, 30 Sep 2026 14:09:09 +0900
Subject: internal/workflows: template common steps

This removes duplicate code and significantly eases maintenance.

Signed-off-by: Ophestra <cat@gensokyo.uk>
---
 internal/workflows/test.go | 153 +++++++--------------------------------------
 1 file changed, 21 insertions(+), 132 deletions(-)

(limited to 'internal/workflows/test.go')

diff --git a/internal/workflows/test.go b/internal/workflows/test.go
index 1bbb04f9..a6a2abc9 100644
--- a/internal/workflows/test.go
+++ b/internal/workflows/test.go
@@ -12,31 +12,9 @@ var _ = (&Workflow{
 			On:   "nix",
 
 			Steps: []Step{
-				{
-					Name: "Checkout",
-					Uses: "actions/checkout@v4",
-				},
-
-				{
-					Name: "Run NixOS test",
-					Run: "nix build " +
-						"--out-link result " +
-						"--print-out-paths " +
-						"--print-build-logs " +
-						"./test#checks.x86_64-linux.hakurei",
-				},
-
-				{
-					Name: "Upload test output",
-					Uses: "actions/upload-artifact@v3",
-
-					With: Map[any]{
-						{K: "name", V: "hakurei-vm-output"},
-						{K: "path", V: "result/*"},
-
-						{K: "retention-days", V: 1},
-					},
-				},
+				checkout,
+				newNixOSTest("hakurei"),
+				newUploadArtifact("test output", "hakurei-vm-output"),
 			},
 		}},
 
@@ -45,28 +23,9 @@ var _ = (&Workflow{
 			On:   "nix",
 
 			Steps: []Step{
-				{Name: "Checkout", Uses: "actions/checkout@v4"},
-
-				{
-					Name: "Run NixOS test",
-					Run: "nix build " +
-						"--out-link result " +
-						"--print-out-paths " +
-						"--print-build-logs " +
-						"./test#checks.x86_64-linux.race",
-				},
-
-				{
-					Name: "Upload test output",
-					Uses: "actions/upload-artifact@v3",
-
-					With: Map[any]{
-						{K: "name", V: "hakurei-race-vm-output"},
-						{K: "path", V: "result/*"},
-
-						{K: "retention-days", V: 1},
-					},
-				},
+				checkout,
+				newNixOSTest("race"),
+				newUploadArtifact("test output", "hakurei-race-vm-output"),
 			},
 		}},
 
@@ -75,28 +34,9 @@ var _ = (&Workflow{
 			On:   "nix",
 
 			Steps: []Step{
-				{Name: "Checkout", Uses: "actions/checkout@v4"},
-
-				{
-					Name: "Run NixOS test",
-					Run: "nix build " +
-						"--out-link result " +
-						"--print-out-paths " +
-						"--print-build-logs " +
-						"./test#checks.x86_64-linux.sandbox",
-				},
-
-				{
-					Name: "Upload test output",
-					Uses: "actions/upload-artifact@v3",
-
-					With: Map[any]{
-						{K: "name", V: "sandbox-vm-output"},
-						{K: "path", V: "result/*"},
-
-						{K: "retention-days", V: 1},
-					},
-				},
+				checkout,
+				newNixOSTest("sandbox"),
+				newUploadArtifact("test output", "sandbox-vm-output"),
 			},
 		}},
 
@@ -105,28 +45,9 @@ var _ = (&Workflow{
 			On:   "nix",
 
 			Steps: []Step{
-				{Name: "Checkout", Uses: "actions/checkout@v4"},
-
-				{
-					Name: "Run NixOS test",
-					Run: "nix build " +
-						"--out-link result " +
-						"--print-out-paths " +
-						"--print-build-logs " +
-						"./test#checks.x86_64-linux.sandbox-race",
-				},
-
-				{
-					Name: "Upload test output",
-					Uses: "actions/upload-artifact@v3",
-
-					With: Map[any]{
-						{K: "name", V: "sandbox-race-vm-output"},
-						{K: "path", V: "result/*"},
-
-						{K: "retention-days", V: 1},
-					},
-				},
+				checkout,
+				newNixOSTest("sandbox-race"),
+				newUploadArtifact("test output", "sandbox-race-vm-output"),
 			},
 		}},
 
@@ -135,28 +56,9 @@ var _ = (&Workflow{
 			On:   "nix",
 
 			Steps: []Step{
-				{Name: "Checkout", Uses: "actions/checkout@v4"},
-
-				{
-					Name: "Run NixOS test",
-					Run: "nix build " +
-						"--out-link result " +
-						"--print-out-paths " +
-						"--print-build-logs " +
-						"./test#checks.x86_64-linux.sharefs",
-				},
-
-				{
-					Name: "Upload test output",
-					Uses: "actions/upload-artifact@v3",
-
-					With: Map[any]{
-						{K: "name", V: "sharefs-vm-output"},
-						{K: "path", V: "result/*"},
-
-						{K: "retention-days", V: 1},
-					},
-				},
+				checkout,
+				newNixOSTest("sharefs"),
+				newUploadArtifact("test output", "sharefs-vm-output"),
 			},
 		}},
 
@@ -173,10 +75,7 @@ var _ = (&Workflow{
 			},
 
 			Steps: []Step{
-				{
-					Name: "Checkout",
-					Uses: "actions/checkout@v4",
-				},
+				checkout,
 
 				{
 					Name: "Run checks",
@@ -193,10 +92,7 @@ var _ = (&Workflow{
 			On:   "nix",
 
 			Steps: []Step{
-				{
-					Name: "Checkout",
-					Uses: "actions/checkout@v4",
-				},
+				checkout,
 
 				{
 					Name: "Build for test",
@@ -210,17 +106,10 @@ var _ = (&Workflow{
 						"echo \"rev=$HAKUREI_REV\" >> $GITHUB_OUTPUT",
 				},
 
-				{
-					Name: "Upload test build",
-					Uses: "actions/upload-artifact@v3",
-
-					With: Map[any]{
-						{K: "name", V: "hakurei-${{ steps.build-test.outputs.rev }}"},
-						{K: "path", V: "result/*"},
-
-						{K: "retention-days", V: 1},
-					},
-				},
+				newUploadArtifact(
+					"test build",
+					"hakurei-${{ steps.build-test.outputs.rev }}",
+				),
 			},
 		}},
 	},
-- 
cgit v1.3.1