From d87020f0ca6897fbc1ba815fc1d9d048795e8749 Mon Sep 17 00:00:00 2001 From: Ophestra Date: Sun, 19 Oct 2025 02:39:23 +0900 Subject: hst/config: validate env early This should happen in hst since it requires no system state. Signed-off-by: Ophestra --- hst/config_test.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'hst/config_test.go') diff --git a/hst/config_test.go b/hst/config_test.go index f3690eb8..6bc878a7 100644 --- a/hst/config_test.go +++ b/hst/config_test.go @@ -39,6 +39,20 @@ func TestConfigValidate(t *testing.T) { Shell: fhs.AbsTmp, }}, &hst.AppError{Step: "validate configuration", Err: hst.ErrConfigNull, Msg: "container configuration missing path to initial program"}}, + {"env equals", &hst.Config{Container: &hst.ContainerConfig{ + Home: fhs.AbsTmp, + Shell: fhs.AbsTmp, + Path: fhs.AbsTmp, + Env: map[string]string{"TERM=": ""}, + }}, &hst.AppError{Step: "validate configuration", Err: hst.ErrEnviron, + Msg: `invalid environment variable "TERM="`}}, + {"env NUL", &hst.Config{Container: &hst.ContainerConfig{ + Home: fhs.AbsTmp, + Shell: fhs.AbsTmp, + Path: fhs.AbsTmp, + Env: map[string]string{"TERM\x00": ""}, + }}, &hst.AppError{Step: "validate configuration", Err: hst.ErrEnviron, + Msg: `invalid environment variable "TERM\x00"`}}, {"valid", &hst.Config{Container: &hst.ContainerConfig{ Home: fhs.AbsTmp, Shell: fhs.AbsTmp, -- cgit v1.3.1