From fe7d208cf76fa6f24bb9d12ba29b5ed61d837ce3 Mon Sep 17 00:00:00 2001 From: Ophestra Date: Thu, 13 Feb 2025 23:15:34 +0900 Subject: helper: use generic extra files interface This replaces the pipes object and integrates context into helper process lifecycle. Signed-off-by: Ophestra --- helper/direct_test.go | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) (limited to 'helper/direct_test.go') diff --git a/helper/direct_test.go b/helper/direct_test.go index 18323572..67b86827 100644 --- a/helper/direct_test.go +++ b/helper/direct_test.go @@ -1,6 +1,7 @@ package helper_test import ( + "context" "errors" "os" "testing" @@ -12,8 +13,8 @@ func TestDirect(t *testing.T) { t.Run("start non-existent helper path", func(t *testing.T) { h := helper.New(argsWt, "/nonexistent", argF) - if err := h.Start(); !errors.Is(err, os.ErrNotExist) { - t.Errorf("Start() error = %v, wantErr %v", + if err := h.Start(context.Background(), false); !errors.Is(err, os.ErrNotExist) { + t.Errorf("Start: error = %v, wantErr %v", err, os.ErrNotExist) } }) @@ -26,18 +27,6 @@ func TestDirect(t *testing.T) { } }) - t.Run("invalid new helper panic", func(t *testing.T) { - defer func() { - wantPanic := "attempted to create helper with invalid argument writer" - if r := recover(); r != wantPanic { - t.Errorf("New: panic = %q, want %q", - r, wantPanic) - } - }() - - helper.New(nil, "fortify", argF) - }) - t.Run("implementation compliance", func(t *testing.T) { testHelper(t, func() helper.Helper { return helper.New(argsWt, "crash-test-dummy", argF) }) }) -- cgit v1.3.1