From 5d8a2199b6c8dc5f75b529a39d196c6cb14c98c2 Mon Sep 17 00:00:00 2001 From: Ophestra Date: Thu, 21 Aug 2025 00:18:50 +0900 Subject: container/init: op interface valid method Check ops early and eliminate duplicate checks. Signed-off-by: Ophestra --- container/initdev.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'container/initdev.go') diff --git a/container/initdev.go b/container/initdev.go index 71c30f42..48d70f37 100644 --- a/container/initdev.go +++ b/container/initdev.go @@ -33,11 +33,9 @@ type MountDevOp struct { Write bool } +func (d *MountDevOp) Valid() bool { return d != nil && d.Target != nil } func (d *MountDevOp) early(*setupState) error { return nil } func (d *MountDevOp) apply(state *setupState) error { - if d.Target == nil { - return EBADE - } target := toSysroot(d.Target.String()) if err := mountTmpfs(SourceTmpfsDevtmpfs, target, MS_NOSUID|MS_NODEV, 0, state.ParentPerm); err != nil { @@ -128,9 +126,10 @@ func (d *MountDevOp) apply(state *setupState) error { func (d *MountDevOp) Is(op Op) bool { vd, ok := op.(*MountDevOp) - return ok && ((d == nil && vd == nil) || (d != nil && vd != nil && - d.Target != nil && vd.Target != nil && d.Target.Is(vd.Target) && - d.Mqueue == vd.Mqueue && d.Write == vd.Write)) + return ok && d.Valid() && vd.Valid() && + d.Target.Is(vd.Target) && + d.Mqueue == vd.Mqueue && + d.Write == vd.Write } func (*MountDevOp) prefix() string { return "mounting" } func (d *MountDevOp) String() string { -- cgit v1.3.1