From a6e5cfdf2e7a5b6620b1b2b0f770ce484d749be3 Mon Sep 17 00:00:00 2001 From: Ophestra Date: Fri, 20 Nov 2026 01:38:12 +0900 Subject: internal/testsuite: fail on early instance termination An early termination is not always caught by onDone. This could leave the test suite scanning forever if not handled. Signed-off-by: Ophestra --- internal/testsuite/testsuite.go | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/internal/testsuite/testsuite.go b/internal/testsuite/testsuite.go index e6bc3a49..32d5e1ba 100644 --- a/internal/testsuite/testsuite.go +++ b/internal/testsuite/testsuite.go @@ -797,8 +797,13 @@ func StartHakurei( processCommand(cmd) } + var onDoneReached atomic.Bool done := MustStart(cmd) - wg.Go(func() { _err := <-done; onDone(_err, output.String()) }) + wg.Go(func() { + _err := <-done + onDoneReached.Store(true) + onDone(_err, output.String()) + }) if err = errors.Join( _notify.Close(), @@ -874,6 +879,13 @@ func StartHakurei( var stat syscall.Stat_t pid = MustScanFor(func() { + if onDoneReached.Load() { + log.Fatalf( + "%s terminated while scanning\n%s", + c.Container.Hostname, + output.String(), + ) + } log.Printf( "still scanning for %s, output:\n%s", c.Container.Hostname, -- cgit v1.3.1