diff options
Diffstat (limited to 'internal')
| -rw-r--r-- | internal/outcome/outcome.go | 1 | ||||
| -rw-r--r-- | internal/outcome/run_test.go | 56 | ||||
| -rw-r--r-- | internal/outcome/shim_test.go | 2 | ||||
| -rw-r--r-- | internal/outcome/sppulse.go | 2 | ||||
| -rw-r--r-- | internal/outcome/sppulse_test.go | 42 | ||||
| -rw-r--r-- | internal/outcome/spruntime.go | 5 | ||||
| -rw-r--r-- | internal/outcome/spruntime_test.go | 8 | ||||
| -rw-r--r-- | internal/store/data_test.go | 4 |
8 files changed, 60 insertions, 60 deletions
diff --git a/internal/outcome/outcome.go b/internal/outcome/outcome.go index 3252db9c..ea01099e 100644 --- a/internal/outcome/outcome.go +++ b/internal/outcome/outcome.go @@ -295,6 +295,7 @@ func (state *outcomeStateSys) toSystem() error { // optional via enablements &spWaylandOp{}, &spX11Op{}, + spPipeWireOp{}, &spPulseOp{}, &spDBusOp{}, diff --git a/internal/outcome/run_test.go b/internal/outcome/run_test.go index 6908cd2f..f2aa1638 100644 --- a/internal/outcome/run_test.go +++ b/internal/outcome/run_test.go @@ -27,7 +27,7 @@ import ( "hakurei.app/message" ) -func TestOutcomeMain(t *testing.T) { +func TestOutcomeRun(t *testing.T) { t.Parallel() msg := message.New(nil) msg.SwapVerbose(testing.Verbose()) @@ -67,18 +67,8 @@ func TestOutcomeMain(t *testing.T) { "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", ). - // ensureRuntimeDir - Ensure(m("/run/user/1971"), 0700). - UpdatePermType(system.User, m("/run/user/1971"), acl.Execute). - Ensure(m("/run/user/1971/hakurei"), 0700). - UpdatePermType(system.User, m("/run/user/1971/hakurei"), acl.Execute). - - // runtime - Ephemeral(system.Process, m("/run/user/1971/hakurei/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"), 0700). - UpdatePerm(m("/run/user/1971/hakurei/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"), acl.Execute). - - // spPulseOp - Link(m("/run/user/1971/pulse/native"), m("/run/user/1971/hakurei/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/pulse")). + // spPipeWireOp + PipeWire(m("/tmp/hakurei.0/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/pipewire")). // spDBusOp MustProxyDBus( @@ -106,8 +96,7 @@ func TestOutcomeMain(t *testing.T) { "GOOGLE_DEFAULT_CLIENT_ID=77185425430.apps.googleusercontent.com", "GOOGLE_DEFAULT_CLIENT_SECRET=OTJgUOQcT7lO7GsGZq2G4IlT", "HOME=/data/data/org.chromium.Chromium", - "PULSE_COOKIE=/.hakurei/pulse-cookie", - "PULSE_SERVER=unix:/run/user/1971/pulse/native", + "PIPEWIRE_REMOTE=/run/user/1971/pipewire-0", "SHELL=/run/current-system/sw/bin/zsh", "TERM=xterm-256color", "USER=chronos", @@ -144,7 +133,7 @@ func TestOutcomeMain(t *testing.T) { Tmpfs(fhs.AbsDevShm, 0, 01777). // spRuntimeOp - Tmpfs(fhs.AbsRunUser, 1<<12, 0755). + Tmpfs(fhs.AbsRunUser, xdgRuntimeDirSize, 0755). Bind(m("/tmp/hakurei.0/runtime/9"), m("/run/user/1971"), std.BindWritable). // spTmpdirOp @@ -157,9 +146,8 @@ func TestOutcomeMain(t *testing.T) { // spWaylandOp Bind(m("/tmp/hakurei.0/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/wayland"), m("/run/user/1971/wayland-0"), 0). - // spPulseOp - Bind(m("/run/user/1971/hakurei/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/pulse"), m("/run/user/1971/pulse/native"), 0). - Place(m("/.hakurei/pulse-cookie"), bytes.Repeat([]byte{0}, pulseCookieSizeMax)). + // spPipeWireOp + Bind(m("/tmp/hakurei.0/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/pipewire"), m("/run/user/1971/pipewire-0"), 0). // spDBusOp Bind(m("/tmp/hakurei.0/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/bus"), m("/run/user/1971/bus"), 0). @@ -244,7 +232,7 @@ func TestOutcomeMain(t *testing.T) { Tmpfs(hst.AbsPrivateTmp, 4096, 0755). DevWritable(m("/dev/"), true). Tmpfs(m("/dev/shm/"), 0, 01777). - Tmpfs(m("/run/user/"), 4096, 0755). + Tmpfs(m("/run/user/"), xdgRuntimeDirSize, 0755). Bind(m("/tmp/hakurei.0/runtime/0"), m("/run/user/65534"), std.BindWritable). Bind(m("/tmp/hakurei.0/tmpdir/0"), m("/tmp/"), std.BindWritable). Place(m("/etc/passwd"), []byte("chronos:x:65534:65534:Hakurei:/home/chronos:/run/current-system/sw/bin/zsh\n")). @@ -298,7 +286,7 @@ func TestOutcomeMain(t *testing.T) { }, Filter: true, }, - Enablements: hst.NewEnablements(hst.EWayland | hst.EDBus | hst.EPulse), + Enablements: hst.NewEnablements(hst.EWayland | hst.EDBus | hst.EPipeWire | hst.EPulse), Container: &hst.ContainerConfig{ Filesystem: []hst.FilesystemConfigJSON{ @@ -347,10 +335,7 @@ func TestOutcomeMain(t *testing.T) { Ensure(m("/tmp/hakurei.0/tmpdir/9"), 01700).UpdatePermType(system.User, m("/tmp/hakurei.0/tmpdir/9"), acl.Read, acl.Write, acl.Execute). Ephemeral(system.Process, m("/tmp/hakurei.0/ebf083d1b175911782d413369b64ce7c"), 0711). Wayland(m("/tmp/hakurei.0/ebf083d1b175911782d413369b64ce7c/wayland"), m("/run/user/1971/wayland-0"), "org.chromium.Chromium", "ebf083d1b175911782d413369b64ce7c"). - Ensure(m("/run/user/1971"), 0700).UpdatePermType(system.User, m("/run/user/1971"), acl.Execute). // this is ordered as is because the previous Ensure only calls mkdir if XDG_RUNTIME_DIR is unset - Ensure(m("/run/user/1971/hakurei"), 0700).UpdatePermType(system.User, m("/run/user/1971/hakurei"), acl.Execute). - Ephemeral(system.Process, m("/run/user/1971/hakurei/ebf083d1b175911782d413369b64ce7c"), 0700).UpdatePermType(system.Process, m("/run/user/1971/hakurei/ebf083d1b175911782d413369b64ce7c"), acl.Execute). - Link(m("/run/user/1971/pulse/native"), m("/run/user/1971/hakurei/ebf083d1b175911782d413369b64ce7c/pulse")). + PipeWire(m("/tmp/hakurei.0/ebf083d1b175911782d413369b64ce7c/pipewire")). MustProxyDBus(&hst.BusConfig{ Talk: []string{ "org.freedesktop.Notifications", @@ -397,8 +382,7 @@ func TestOutcomeMain(t *testing.T) { "DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/65534/bus", "DBUS_SYSTEM_BUS_ADDRESS=unix:path=/var/run/dbus/system_bus_socket", "HOME=/home/chronos", - "PULSE_COOKIE=" + hst.PrivateTmp + "/pulse-cookie", - "PULSE_SERVER=unix:/run/user/65534/pulse/native", + "PIPEWIRE_REMOTE=/run/user/65534/pipewire-0", "SHELL=/run/current-system/sw/bin/zsh", "TERM=xterm-256color", "USER=chronos", @@ -413,14 +397,13 @@ func TestOutcomeMain(t *testing.T) { Tmpfs(hst.AbsPrivateTmp, 4096, 0755). DevWritable(m("/dev/"), true). Tmpfs(m("/dev/shm/"), 0, 01777). - Tmpfs(m("/run/user/"), 4096, 0755). + Tmpfs(m("/run/user/"), xdgRuntimeDirSize, 0755). Bind(m("/tmp/hakurei.0/runtime/9"), m("/run/user/65534"), std.BindWritable). Bind(m("/tmp/hakurei.0/tmpdir/9"), m("/tmp/"), std.BindWritable). Place(m("/etc/passwd"), []byte("chronos:x:65534:65534:Hakurei:/home/chronos:/run/current-system/sw/bin/zsh\n")). Place(m("/etc/group"), []byte("hakurei:x:65534:\n")). Bind(m("/tmp/hakurei.0/ebf083d1b175911782d413369b64ce7c/wayland"), m("/run/user/65534/wayland-0"), 0). - Bind(m("/run/user/1971/hakurei/ebf083d1b175911782d413369b64ce7c/pulse"), m("/run/user/65534/pulse/native"), 0). - Place(m(hst.PrivateTmp+"/pulse-cookie"), bytes.Repeat([]byte{0}, pulseCookieSizeMax)). + Bind(m("/tmp/hakurei.0/ebf083d1b175911782d413369b64ce7c/pipewire"), m("/run/user/65534/pipewire-0"), 0). Bind(m("/tmp/hakurei.0/ebf083d1b175911782d413369b64ce7c/bus"), m("/run/user/65534/bus"), 0). Bind(m("/tmp/hakurei.0/ebf083d1b175911782d413369b64ce7c/system_bus_socket"), m("/var/run/dbus/system_bus_socket"), 0). Bind(m("/dev/dri"), m("/dev/dri"), std.BindWritable|std.BindDevice|std.BindOptional). @@ -440,7 +423,7 @@ func TestOutcomeMain(t *testing.T) { {"nixos chromium direct wayland", new(stubNixOS), &hst.Config{ ID: "org.chromium.Chromium", - Enablements: hst.NewEnablements(hst.EWayland | hst.EDBus | hst.EPulse), + Enablements: hst.NewEnablements(hst.EWayland | hst.EDBus | hst.EPipeWire | hst.EPulse), Container: &hst.ContainerConfig{ Env: nil, Filesystem: []hst.FilesystemConfigJSON{ @@ -502,9 +485,8 @@ func TestOutcomeMain(t *testing.T) { Ensure(m("/run/user/1971"), 0700).UpdatePermType(system.User, m("/run/user/1971"), acl.Execute). // this is ordered as is because the previous Ensure only calls mkdir if XDG_RUNTIME_DIR is unset Ensure(m("/run/user/1971/hakurei"), 0700).UpdatePermType(system.User, m("/run/user/1971/hakurei"), acl.Execute). UpdatePermType(hst.EWayland, m("/run/user/1971/wayland-0"), acl.Read, acl.Write, acl.Execute). - Ephemeral(system.Process, m("/run/user/1971/hakurei/8e2c76b066dabe574cf073bdb46eb5c1"), 0700).UpdatePermType(system.Process, m("/run/user/1971/hakurei/8e2c76b066dabe574cf073bdb46eb5c1"), acl.Execute). - Link(m("/run/user/1971/pulse/native"), m("/run/user/1971/hakurei/8e2c76b066dabe574cf073bdb46eb5c1/pulse")). Ephemeral(system.Process, m("/tmp/hakurei.0/8e2c76b066dabe574cf073bdb46eb5c1"), 0711). + PipeWire(m("/tmp/hakurei.0/8e2c76b066dabe574cf073bdb46eb5c1/pipewire")). MustProxyDBus(&hst.BusConfig{ Talk: []string{ "org.freedesktop.FileManager1", "org.freedesktop.Notifications", @@ -544,8 +526,7 @@ func TestOutcomeMain(t *testing.T) { "DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1971/bus", "DBUS_SYSTEM_BUS_ADDRESS=unix:path=/var/run/dbus/system_bus_socket", "HOME=/var/lib/persist/module/hakurei/0/1", - "PULSE_COOKIE=" + hst.PrivateTmp + "/pulse-cookie", - "PULSE_SERVER=unix:/run/user/1971/pulse/native", + "PIPEWIRE_REMOTE=/run/user/1971/pipewire-0", "SHELL=/run/current-system/sw/bin/zsh", "TERM=xterm-256color", "USER=u0_a1", @@ -559,14 +540,13 @@ func TestOutcomeMain(t *testing.T) { Tmpfs(hst.AbsPrivateTmp, 4096, 0755). DevWritable(m("/dev/"), true). Tmpfs(m("/dev/shm/"), 0, 01777). - Tmpfs(m("/run/user/"), 4096, 0755). + Tmpfs(m("/run/user/"), xdgRuntimeDirSize, 0755). Bind(m("/tmp/hakurei.0/runtime/1"), m("/run/user/1971"), std.BindWritable). Bind(m("/tmp/hakurei.0/tmpdir/1"), m("/tmp/"), std.BindWritable). Place(m("/etc/passwd"), []byte("u0_a1:x:1971:100:Hakurei:/var/lib/persist/module/hakurei/0/1:/run/current-system/sw/bin/zsh\n")). Place(m("/etc/group"), []byte("hakurei:x:100:\n")). Bind(m("/run/user/1971/wayland-0"), m("/run/user/1971/wayland-0"), 0). - Bind(m("/run/user/1971/hakurei/8e2c76b066dabe574cf073bdb46eb5c1/pulse"), m("/run/user/1971/pulse/native"), 0). - Place(m(hst.PrivateTmp+"/pulse-cookie"), bytes.Repeat([]byte{0}, pulseCookieSizeMax)). + Bind(m("/tmp/hakurei.0/8e2c76b066dabe574cf073bdb46eb5c1/pipewire"), m("/run/user/1971/pipewire-0"), 0). Bind(m("/tmp/hakurei.0/8e2c76b066dabe574cf073bdb46eb5c1/bus"), m("/run/user/1971/bus"), 0). Bind(m("/tmp/hakurei.0/8e2c76b066dabe574cf073bdb46eb5c1/system_bus_socket"), m("/var/run/dbus/system_bus_socket"), 0). Bind(m("/bin"), m("/bin"), 0). diff --git a/internal/outcome/shim_test.go b/internal/outcome/shim_test.go index 147607fa..532a2c77 100644 --- a/internal/outcome/shim_test.go +++ b/internal/outcome/shim_test.go @@ -69,7 +69,7 @@ func TestShimEntrypoint(t *testing.T) { Tmpfs(fhs.AbsDevShm, 0, 01777). // spRuntimeOp - Tmpfs(fhs.AbsRunUser, 1<<12, 0755). + Tmpfs(fhs.AbsRunUser, xdgRuntimeDirSize, 0755). Bind(m("/tmp/hakurei.10/runtime/9999"), m("/run/user/1000"), std.BindWritable). // spTmpdirOp diff --git a/internal/outcome/sppulse.go b/internal/outcome/sppulse.go index a2dc2401..e86fb3f8 100644 --- a/internal/outcome/sppulse.go +++ b/internal/outcome/sppulse.go @@ -29,7 +29,7 @@ type spPulseOp struct { } func (s *spPulseOp) toSystem(state *outcomeStateSys) error { - if state.et&hst.EPulse == 0 { + if !state.directPulse || state.et&hst.EPulse == 0 { return errNotEnabled } diff --git a/internal/outcome/sppulse_test.go b/internal/outcome/sppulse_test.go index 4ec445db..70fae9e9 100644 --- a/internal/outcome/sppulse_test.go +++ b/internal/outcome/sppulse_test.go @@ -18,24 +18,40 @@ import ( func TestSpPulseOp(t *testing.T) { t.Parallel() - config := hst.Template() + newConfig := func() *hst.Config { + config := hst.Template() + config.DirectPulse = true + config.Enablements = hst.NewEnablements(hst.EPulse) + return config + } + + config := newConfig() sampleCookie := bytes.Repeat([]byte{0xfc}, pulseCookieSizeMax) checkOpBehaviour(t, []opBehaviourTestCase{ {"not enabled", func(bool, bool) outcomeOp { return new(spPulseOp) }, func() *hst.Config { - c := hst.Template() + c := newConfig() + c.DirectPulse = true *c.Enablements = 0 return c }, nil, nil, nil, nil, errNotEnabled, nil, nil, nil, nil, nil}, + {"not enabled direct", func(bool, bool) outcomeOp { + return new(spPulseOp) + }, func() *hst.Config { + c := newConfig() + c.DirectPulse = false + return c + }, nil, nil, nil, nil, errNotEnabled, nil, nil, nil, nil, nil}, + {"socketDir stat", func(isShim, _ bool) outcomeOp { if !isShim { return new(spPulseOp) } return &spPulseOp{Cookie: (*[256]byte)(sampleCookie)} - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), stub.UniqueError(2)), }, nil, nil, &hst.AppError{ Step: `access PulseAudio directory "/proc/nonexistent/xdg_runtime_dir/pulse"`, @@ -44,7 +60,7 @@ func TestSpPulseOp(t *testing.T) { {"socketDir nonexistent", func(bool, bool) outcomeOp { return new(spPulseOp) - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), os.ErrNotExist), }, nil, nil, &hst.AppError{ Step: "finalise", @@ -54,7 +70,7 @@ func TestSpPulseOp(t *testing.T) { {"socket stat", func(bool, bool) outcomeOp { return new(spPulseOp) - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), nil), call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse/native"}, (*stubFi)(nil), stub.UniqueError(1)), }, nil, nil, &hst.AppError{ @@ -64,7 +80,7 @@ func TestSpPulseOp(t *testing.T) { {"socket nonexistent", func(bool, bool) outcomeOp { return new(spPulseOp) - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), nil), call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse/native"}, (*stubFi)(nil), os.ErrNotExist), }, nil, nil, &hst.AppError{ @@ -75,7 +91,7 @@ func TestSpPulseOp(t *testing.T) { {"socket mode", func(bool, bool) outcomeOp { return new(spPulseOp) - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), nil), call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse/native"}, &stubFi{mode: 0660}, nil), }, nil, nil, &hst.AppError{ @@ -86,7 +102,7 @@ func TestSpPulseOp(t *testing.T) { {"cookie notAbs", func(bool, bool) outcomeOp { return new(spPulseOp) - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), nil), call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse/native"}, &stubFi{mode: 0666}, nil), call("lookupEnv", stub.ExpectArgs{"PULSE_COOKIE"}, "proc/nonexistent/cookie", nil), @@ -97,7 +113,7 @@ func TestSpPulseOp(t *testing.T) { {"cookie loadFile", func(bool, bool) outcomeOp { return new(spPulseOp) - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), nil), call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse/native"}, &stubFi{mode: 0666}, nil), call("lookupEnv", stub.ExpectArgs{"PULSE_COOKIE"}, "/proc/nonexistent/cookie", nil), @@ -118,7 +134,7 @@ func TestSpPulseOp(t *testing.T) { op.CookieSize += +0xfd } return op - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), nil), call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse/native"}, &stubFi{mode: 0666}, nil), call("lookupEnv", stub.ExpectArgs{"PULSE_COOKIE"}, "/proc/nonexistent/cookie", nil), @@ -150,7 +166,7 @@ func TestSpPulseOp(t *testing.T) { sampleCookieTrunc := make([]byte, pulseCookieSizeMax) copy(sampleCookieTrunc, sampleCookie[:len(sampleCookie)-0xe]) return &spPulseOp{Cookie: (*[pulseCookieSizeMax]byte)(sampleCookieTrunc), CookieSize: pulseCookieSizeMax - 0xe} - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), nil), call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse/native"}, &stubFi{mode: 0666}, nil), call("lookupEnv", stub.ExpectArgs{"PULSE_COOKIE"}, "/proc/nonexistent/cookie", nil), @@ -183,7 +199,7 @@ func TestSpPulseOp(t *testing.T) { return new(spPulseOp) } return &spPulseOp{Cookie: (*[pulseCookieSizeMax]byte)(sampleCookie), CookieSize: pulseCookieSizeMax} - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), nil), call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse/native"}, &stubFi{mode: 0666}, nil), call("lookupEnv", stub.ExpectArgs{"PULSE_COOKIE"}, "/proc/nonexistent/cookie", nil), @@ -213,7 +229,7 @@ func TestSpPulseOp(t *testing.T) { {"success", func(bool, bool) outcomeOp { return new(spPulseOp) - }, hst.Template, nil, []stub.Call{ + }, newConfig, nil, []stub.Call{ call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse"}, (*stubFi)(nil), nil), call("stat", stub.ExpectArgs{wantRuntimePath + "/pulse/native"}, &stubFi{mode: 0666}, nil), call("lookupEnv", stub.ExpectArgs{"PULSE_COOKIE"}, nil, nil), diff --git a/internal/outcome/spruntime.go b/internal/outcome/spruntime.go index 1e066bd4..6ec532bb 100644 --- a/internal/outcome/spruntime.go +++ b/internal/outcome/spruntime.go @@ -91,6 +91,9 @@ func (s *spRuntimeOp) toSystem(state *outcomeStateSys) error { return nil } +// xdgRuntimeDirSize is the size of the filesystem mounted on inner XDG_RUNTIME_DIR. +const xdgRuntimeDirSize = 1 << 24 + func (s *spRuntimeOp) toContainer(state *outcomeStateParams) error { state.runtimeDir = fhs.AbsRunUser.Append(state.mapuid.String()) state.env[envXDGRuntimeDir] = state.runtimeDir.String() @@ -108,7 +111,7 @@ func (s *spRuntimeOp) toContainer(state *outcomeStateParams) error { } - state.params.Tmpfs(fhs.AbsRunUser, 1<<12, 0755) + state.params.Tmpfs(fhs.AbsRunUser, xdgRuntimeDirSize, 0755) if state.Container.Flags&hst.FShareRuntime != 0 { _, runtimeDirInst := s.commonPaths(state.outcomeState) state.params.Bind(runtimeDirInst, state.runtimeDir, std.BindWritable) diff --git a/internal/outcome/spruntime_test.go b/internal/outcome/spruntime_test.go index 18f3ce9c..58cf90d7 100644 --- a/internal/outcome/spruntime_test.go +++ b/internal/outcome/spruntime_test.go @@ -40,7 +40,7 @@ func TestSpRuntimeOp(t *testing.T) { // this op configures the container state and does not make calls during toContainer }, &container.Params{ Ops: new(container.Ops). - Tmpfs(fhs.AbsRunUser, 1<<12, 0755). + Tmpfs(fhs.AbsRunUser, xdgRuntimeDirSize, 0755). Bind(m("/proc/nonexistent/tmp/hakurei.0/runtime/9"), m("/run/user/1000"), std.BindWritable), }, paramsWantEnv(config, map[string]string{ "XDG_RUNTIME_DIR": "/run/user/1000", @@ -67,7 +67,7 @@ func TestSpRuntimeOp(t *testing.T) { // this op configures the container state and does not make calls during toContainer }, &container.Params{ Ops: new(container.Ops). - Tmpfs(fhs.AbsRunUser, 1<<12, 0755). + Tmpfs(fhs.AbsRunUser, xdgRuntimeDirSize, 0755). Bind(m("/proc/nonexistent/tmp/hakurei.0/runtime/9"), m("/run/user/1000"), std.BindWritable), }, paramsWantEnv(config, map[string]string{ "XDG_RUNTIME_DIR": "/run/user/1000", @@ -94,7 +94,7 @@ func TestSpRuntimeOp(t *testing.T) { // this op configures the container state and does not make calls during toContainer }, &container.Params{ Ops: new(container.Ops). - Tmpfs(fhs.AbsRunUser, 1<<12, 0755). + Tmpfs(fhs.AbsRunUser, xdgRuntimeDirSize, 0755). Bind(m("/proc/nonexistent/tmp/hakurei.0/runtime/9"), m("/run/user/1000"), std.BindWritable), }, paramsWantEnv(config, map[string]string{ "XDG_RUNTIME_DIR": "/run/user/1000", @@ -117,7 +117,7 @@ func TestSpRuntimeOp(t *testing.T) { // this op configures the container state and does not make calls during toContainer }, &container.Params{ Ops: new(container.Ops). - Tmpfs(fhs.AbsRunUser, 1<<12, 0755). + Tmpfs(fhs.AbsRunUser, xdgRuntimeDirSize, 0755). Bind(m("/proc/nonexistent/tmp/hakurei.0/runtime/9"), m("/run/user/1000"), std.BindWritable), }, paramsWantEnv(config, map[string]string{ "XDG_RUNTIME_DIR": "/run/user/1000", diff --git a/internal/store/data_test.go b/internal/store/data_test.go index a2eb92cd..fe0e2124 100644 --- a/internal/store/data_test.go +++ b/internal/store/data_test.go @@ -47,9 +47,9 @@ func TestEntryData(t *testing.T) { {"inconsistent enablement", "\x00\xff\xca\xfe\x00\x00\xff\x00" + templateStateGob, NewTemplateState(), &hst.AppError{ Step: "validate state enablement", Err: os.ErrInvalid, - Msg: "state entry aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa has unexpected enablement byte 0x1d, 0xff"}}, + Msg: "state entry aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa has unexpected enablement byte 0xd, 0xff"}}, - {"template", "\x00\xff\xca\xfe\x00\x00\x1d\xe2" + templateStateGob, NewTemplateState(), nil}, + {"template", "\x00\xff\xca\xfe\x00\x00\x0d\xf2" + templateStateGob, NewTemplateState(), nil}, } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { |
