diff options
| author | Ophestra <cat@gensokyo.uk> | 2025-12-26 05:28:45 +0900 |
|---|---|---|
| committer | Ophestra <cat@gensokyo.uk> | 2025-12-26 05:28:45 +0900 |
| commit | b77c1ecfdb545f41fbf847681ac75f29d7998ad9 (patch) | |
| tree | 42abe06fc45241ca913cd9cb5ce9ade885231283 /cmd/sharefs/test/test.py | |
| parent | dce5839a797409bf6b58273fb343764a56f91bbf (diff) | |
cmd/sharefs/test: check option handling
This verifies behaviour related to setuid/setgid when starting as root.
Signed-off-by: Ophestra <cat@gensokyo.uk>
Diffstat (limited to 'cmd/sharefs/test/test.py')
| -rw-r--r-- | cmd/sharefs/test/test.py | 27 |
1 files changed, 26 insertions, 1 deletions
diff --git a/cmd/sharefs/test/test.py b/cmd/sharefs/test/test.py index 58062e02..9b30379c 100644 --- a/cmd/sharefs/test/test.py +++ b/cmd/sharefs/test/test.py @@ -1,6 +1,31 @@ start_all() machine.wait_for_unit("multi-user.target") +def check_bad_opts_output(opts, want, privileged=False): + output = machine.fail(("" if privileged else "sudo -u alice -i ") + f"/etc/sharefs -f -o source=/proc/nonexistent,{opts} /mnt 2>&1") + if output != want: + raise Exception(f"unexpected output: {output}") + +# Malformed setuid/setgid representation: +check_bad_opts_output("setuid=ff", "sharefs: invalid value for option setuid\n") +check_bad_opts_output("setgid=ff", "sharefs: invalid value for option setgid\n") + +# Bounds check for setuid/setgid: +check_bad_opts_output("setuid=0", "sharefs: invalid value for option setuid\n") +check_bad_opts_output("setgid=0", "sharefs: invalid value for option setgid\n") +check_bad_opts_output("setuid=-1", "sharefs: invalid value for option setuid\n") +check_bad_opts_output("setgid=-1", "sharefs: invalid value for option setgid\n") + +# Non-root setuid/setgid: +check_bad_opts_output("setuid=1023", "sharefs: setuid and setgid has no effect when not starting as root\n") +check_bad_opts_output("setgid=1023", "sharefs: setuid and setgid has no effect when not starting as root\n") +check_bad_opts_output("setuid=1023,setgid=1023", "sharefs: setuid and setgid has no effect when not starting as root\n") + +# Starting as root without setuid/setgid: +check_bad_opts_output("allow_other", "sharefs: setuid and setgid must not be 0\n", privileged=True) +check_bad_opts_output("setuid=1023", "sharefs: setuid and setgid must not be 0\n", privileged=True) +check_bad_opts_output("setgid=1023", "sharefs: setuid and setgid must not be 0\n", privileged=True) + # Benchmark sharefs: machine.succeed("fs_mark -v -d /sdcard/fs_mark -l /tmp/fs_log.txt") machine.copy_from_vm("/tmp/fs_log.txt", "") @@ -11,4 +36,4 @@ machine.succeed("sudo -u alice rm -rf /sdcard/fs_mark") machine.fail("ls /var/lib/hakurei/sdcard/fs_mark") # Run hakurei tests on sharefs: -machine.succeed("sudo -u alice sharefs-workload-hakurei-tests") +machine.succeed("sudo -u alice -i sharefs-workload-hakurei-tests") |